crashappsec / chalk

Chalk allows you to follow code from development, through builds and into production.
https://crashoverride.com/
GNU General Public License v3.0
322 stars 11 forks source link

ci: bump every external action, fixing Node v16 warnings #321

Closed ee7 closed 3 weeks ago

ee7 commented 4 weeks ago

Bump every external action to the latest version as of the time of this PR's creation.

This resolves some warnings that might turn into errors fairly soon (I think depending on whether any of our currently specified versions break when it's forced to use Node20?). The summary of our workflow runs contained (cleaned up):

Node.js 16 actions are deprecated.

Please update the following actions to use Node.js 20:

  • actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
  • crashappsec/action-github-app-token@main
  • docker/setup-buildx-action@885d1462b80bc1c1c7f0b00334ad271f09369c55
  • docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc

For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

In March 2024, GitHub stated they'd enforce Node20 on 2024-06-03:

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 3rd of June.

but they backpedalled a couple of weeks ago:

Following on from our announcement of the end of Node16 support we have a new timeline for Node16 end of life in Actions.

On June 30th 2024, we will change the default from Node16 to Node20. To opt out of this and continue using Node16 while it is still available in the runner, you can choose to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true

We will then continue to monitor Node16 usage and will communicate a timeline for the removal of Node16 at the start of October, based on the volume of continued use. This means that customers who use the environment variable to continue to use Node16 now have until October to complete their migrations.

Still, let's upgrade.

I believe the major version bumps in the Docker actions are just for the Node 20 bump (because that raises the minimum version of the Runner for GitHub Actions).

See the release pages:


If we print the action versions used in this repo with:

git grep -h 'uses:' -- '.github/workflows' | cut -d':' -f3 | sort | uniq

Before this PR:

actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # 4.1.1
actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # 3.6.0
actions/setup-python@3542bca2639a428e1796aaa6a2ffef0c0f575566 # 3.1.4
crashappsec/action-github-app-token@main
docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # 2.2.0
docker/setup-buildx-action@885d1462b80bc1c1c7f0b00334ad271f09369c55 # 2.10.0
pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507 # 3.0.0

With this PR:

actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # 4.1.6
actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # 5.1.0
crashappsec/action-github-app-token@main
docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # 3.2.0
docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb # 3.3.0
pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # 3.0.1