Closed miki725 closed 3 weeks ago
I've realised the pre-existing tests already assert that semver.parseVersion
silently parses strings that are invalid semantic versions, so no need for any action on that in this PR.
I'll open a low-priority ticket that could be closed with e.g. just a file rename and a couple of comments.
(Approved again).
CHANGELOG.md
if necessaryIssue
when using distroless image without buildx, some builds can fail
Description
When chalk needs to copy both
/chalk.json
and/chalk
in the build, it needs to set correct permissions on the file. Without buildx, as it cannot leverageCOPY --chmod
, Chalk needs to manually adjust permissions by:However for distroless images
RUN
cannot work as there is nochmod
executable and so the build will fail.Now for this case we attempt to use multi-stage builds if possible as we can use
busybox
image which has the capability to runchmod
and then we copy that into the final image. Something like:There is still an edge case where this will fail when docker doesnt support multi-stage builds but at that point we have no other options so wrapping will fail without any other recourse.
Testing