Closed ee7 closed 2 weeks ago
CHANGELOG.md
Continue from #235, #236, and #237, removing (nearly) every remaining access of a ChalkConfig field.
ChalkConfig
With this PR, the remaining field accesses of chalkConfig are the below:
chalkConfig
$ git log -1 --format='%h %s' db26f26 refactor(all): avoid chalkConfig.(mark|report)Templates $ git grep --break --heading --ignore-case 'chalkConfig\.' src/run_management.nim 31: get[T](chalkConfig.`@@attrscope@@`, fqn) 34: getOpt[T](chalkConfig.`@@attrscope@@`, fqn)
Similar to previous PRs, I don't love this class of change, but we can add back some more compile-time safety around this later. The direction was to remove c4autoconf first.
Hopefully the existing tests are sufficient.
CHANGELOG.md
if necessaryIssue
214
Description
Continue from #235, #236, and #237, removing (nearly) every remaining access of a
ChalkConfig
field.With this PR, the remaining field accesses of
chalkConfig
are the below:Similar to previous PRs, I don't love this class of change, but we can add back some more compile-time safety around this later. The direction was to remove c4autoconf first.
Testing
Hopefully the existing tests are sufficient.