crashappsec / chalk

Chalk allows you to follow code from development, through builds and into production.
https://crashoverride.com/
GNU General Public License v3.0
322 stars 11 forks source link

refactor: remove remaining chalkConfig field accesses #329

Closed ee7 closed 2 weeks ago

ee7 commented 3 weeks ago

Issue

214

Description

Continue from #235, #236, and #237, removing (nearly) every remaining access of a ChalkConfig field.

With this PR, the remaining field accesses of chalkConfig are the below:

$ git log -1 --format='%h %s'
db26f26 refactor(all): avoid chalkConfig.(mark|report)Templates
$ git grep --break --heading --ignore-case 'chalkConfig\.'
src/run_management.nim
31:  get[T](chalkConfig.`@@attrscope@@`, fqn)
34:  getOpt[T](chalkConfig.`@@attrscope@@`, fqn)

Similar to previous PRs, I don't love this class of change, but we can add back some more compile-time safety around this later. The direction was to remove c4autoconf first.

Testing

Hopefully the existing tests are sufficient.