crashappsec / chalk

Chalk allows you to follow code from development, through builds and into production.
https://crashoverride.com/
GNU General Public License v3.0
348 stars 15 forks source link

refactor: remove ChalkConfig #330

Closed ee7 closed 3 months ago

ee7 commented 3 months ago

Issue

214

Description

Continue from #235, #236, #237, and #329, removing the last usage of the autogenerated types: ChalkConfig.

In particular, this PR removes from the confload module's loadLocalStructs() procedure:

chalkConfig = state.attrs.loadChalkConfig()

but deliberately makes only minimal changes there otherwise for now, so that these PRs are tightly focused. That is, all the addCallback(loadLocalStructs) calls still exist for now, but they do less.

After this PR, it's easy to remove c4autoconf itself.

With this PR:

$ git log -1 --format='%h %s'
de237f0 refactor: remove chalkConfig
$ git grep --ignore-case 'chalkConfig'
src/configs/chalk.c42spec:2647:  gen_typename: "ChalkConfig"