tag info incorrect on ci build - Githubissues

crashappsec / chalk

Chalk allows you to follow code from development, through builds and into production.

https://crashoverride.com/

GNU General Public License v3.0

348 stars 15 forks source link

tag info incorrect on ci build #332

Closed indecisivedragon closed 3 months ago

indecisivedragon commented 3 months ago

Description

when running build on ci with a repo that has a tag, the tag info should show up in chalk report but is not

we are expecting a section like:

        "TAG": "test_branch_tag",
        "TAGGER": "liming <liming@crashoverride.com> 1718208130 -0400",
        "DATE_TAGGED": "Wed Jun 12 12:02:10 2024 -0400",
        "TAG_SIGNED": false,
        "TAG_MESSAGE": "xxx",

(which happens locally) but on ci this information is not getting populated even though the plugin runs:

trace: Found version control dir: /home/runner/work/dummy-deployments/dummy-deployments/.git
trace: commit ID: 80e2b8558a409fcd7ccd281cd4c828fc64b00007
trace: tag: v0.1
trace: latest tag: v0.1
trace: vctl_git: Plugin called.

Impact

low since no customers are complaining about it at the moment and it hasn't broken anything

Steps to Reproduce

tag a branch (ex dummy deployments)
push to ci and trigger a build
observe chalk report has "TAG_SIGNED": false, even though the tag exists and is signed, and has no other tag info

ee7 commented 3 months ago

It turns out there's a general issue too for the basic git keys. I've opened https://github.com/crashappsec/chalk/issues/342 for that.