search

crashappsec / libcon4m

Base Compiler and Runtime Support for con4m
Apache License 2.0
0 stars 0 forks source link

`dev run` should indicate failure when `c4test` exits non-zero #42

Closed ee7 closed 3 months ago

ee7 commented 3 months ago

Currently, dev run exits with an exit code of 0 even when c4test exits non-zero:

https://github.com/crashappsec/libcon4m/blob/833300442d95e6ca7b49104417873c0c671caa00/dev#L128-L139

ee7 commented 3 months ago

Closed by https://github.com/crashappsec/libcon4m/commit/f7752b2e004d46be14864341a21f3e43a0fac92c.

ee7 commented 3 months ago

PR #60 shows that when there's a SIGSEGV, dev run still exits with an exit code of 0.

It looks like that's because when the c4test exit code is e.g. 139, there's nothing to make dev run exit non-zero:

https://github.com/crashappsec/libcon4m/blob/14604adf6ca68c75a08360129d71beb63571c1d1/dev#L136-L155