search

crashdemons / DisplayItem-Spigot

rewrite of DisplayItem for use in Spigot 1.13+ (uses BungeeChat components)
5 stars 0 forks source link

&k magic text in displayname is forcing whole message to be magic #21

Open iZeusi opened 2 years ago

iZeusi commented 2 years ago

Describe the bug A user has &k magic text in prefix which is part of displayname. They use our [i] to display an item, which makes the whole message randomize like &k magic.

To Reproduce Steps to reproduce the behavior: Add &k to displayname of user. Quickest way would probably be through Essentials /nickname. Then display item in chat.

Expected behavior A clear and concise description of what you expected to happen. Message should show as normal; &k magic should only be in the prefix of the displayname as it is in normal messages.

Screenshots If applicable, add screenshots to help explain your problem. https://gyazo.com/ab79640cc41bdc15f03d110b75f18cc8

Required information Server version text when using /version command? https://gyazo.com/9ef96076945c6096ac8561e26e5968da Plugin version when using /version DisplayItem command? https://gyazo.com/407bd5cbfbac20ec0644e14da4e16176

Important to note this was occurring in the two DisplayItem versions previous.

crashdemons commented 2 years ago

Can you post your plugin config.yml or is it all default?

The config has &r both before the message (when using overridechatformat) and before the item (in the item display config) - which normally should block the formatting from &k... although I think I've noticed this in some testing in the past.

Do you use any chat-formatting plugins (ChatControl, Factions3, EssentialsChat, etc ...) ?

iZeusi commented 2 years ago

Full config: https://pastebin.com/nKpxbZF4

I do use LuckPerms and EssentialsChat yeah. Prefix is taken from LuckPerms which is then formatted in EssentialsChat.

Cheers.

crashdemons commented 2 years ago

sorry about that, I accidentally clicked