search

crashdemons / DisplayItem-Spigot

rewrite of DisplayItem for use in Spigot 1.13+ (uses BungeeChat components)
5 stars 0 forks source link

Meta Replacement does not work as intended #3

Closed RealAkito closed 4 years ago

RealAkito commented 4 years ago

Hey there,

Great plugin here, though I have found out that "metareplacement" does not work as intended.

When I sent [I], it should returned the "item display", but instead returned [item].

If you need any more information, please do tell.

Thanks in advance.

image

RealAkito commented 4 years ago

I have as well tested this plugin on 1.15.2 server as well, it is working as intended, apart from meta replacement as I've addressed on here. You might want to update the repository description.

crashdemons commented 4 years ago

The wiki should be clearer but when you post [I] (or your 'metareplacement' value) it should post in chat your replacement string [i] (or your 'replacement' value).

It was intended so you could use it to tell people what to post.

So if replacement is [item] and metareplacement is [I]

then [I] should display [item] and [item] (separately) should display [your held item name here]

Sorry for the late reply, I didn't get a notification for the issue.

crashdemons commented 4 years ago

I've made changes to the default config and the documentation. Hopefully this should be clearer as to the purpose?

https://github.com/crashdemons/DisplayItem-Spigot/wiki/Configuration https://github.com/crashdemons/DisplayItem-Spigot/blob/master/src/main/resources/config.yml#L2

RealAkito commented 4 years ago

I've made changes to the default config and the documentation. Hopefully this should be clearer as to the purpose?

https://github.com/crashdemons/DisplayItem-Spigot/wiki/Configuration https://github.com/crashdemons/DisplayItem-Spigot/blob/master/src/main/resources/config.yml#L2

Yes it is, that's very nice of you. Thanks for developing such a great plugin that's working as intended :D. Perhaps this issue can be closed now.