Glowstone not recognized as an ore? should it be?

crashdemons / LoreKillCounter

Bukkit plugin that adds kill-counters to weapon ingame-item loretext

2 stars 0 forks source link

Glowstone not recognized as an ore? should it be? #5

Open crashdemons opened 4 years ago

crashdemons commented 4 years ago

what about clay for that matter - or is it because you use a different tool?

EvModder commented 3 years ago

Personal opinion: If the material name ends with "_ore", it is an ore, otherwise it is just a material that requires a special tool.

Related: I believe Bukkit API Material enum provides a dropsSelf() (or something similar), which can be used to identify blocks such as glowstone, clay, gravel, ender_chest etc. that drop "fragments" when not using Silk Touch

crashdemons commented 3 years ago

That was kind of my initial idea with "_ore" also, but I also decided to include ancient debris since it had the same smelting requirement as other metallic ore, so that's where we're at now and maybe it doesn't need fixing... https://github.com/crashdemons/LoreKillCounter/blob/bc072aef9e48c5f954e218d78421f1c87f36d4c3/src/main/java/com/github/crashdemons/lorekillcounter/counters/CounterManager.java#L172

Also, Interesting API method - that may be useful for MiningTrophies, or at least help generate candidates (although I don't know if I want to have a huge list of trophies - it's nice to have smaller goals compared to PH's)