crashmoney / obsidian-typewriter

Typewriter is an Obsidian theme designed for a focused writing experience.
GNU General Public License v3.0
93 stars 18 forks source link

[FEATURE REQUEST] Edges in Graph View lack contrast/visibility. #33

Closed 1b7 closed 6 months ago

1b7 commented 1 year ago

Describe your feature request

Within the Graph view, I personally find it fairly hard to pick out the edges between nodes in the graph. This is especially true of Light Mode. I haven't had this with other themes so I don't believe this is a personal issue.

Here are some screenshots from my graph which I hope illustrate the issue (using a Link Thickness of 1.0 - I would normally use ~0.4 but initially increased this to try and make the lines clearer):

Light Mode

image

Dark Mode

image

Proposed Solution

I think a really simple fix is just a change to the .graph-view.color-line class (mentioned here)

As a test, I added the following custom CSS snippet as a quick and hacky solution within my own Obsidian installation:

.graph-view.color-line {
    color: #888;
}

And I think the result is significantly easier to see:

image

All other settings were kept the same between screenshots. #888 was chosen very arbitrarily, I am not suggesting that this should be the colour used - and of course a different colour would need to be used for the dark mode.

(I would also note that using a darker colour allowed me to revert the link thickness back down to my original setting for a softer/less harsh appearance, without sacrificing visibility).

crashmoney commented 6 months ago

Hey @1b7! I've taken a look at your fix, and the class works perfectly. I've changed the color to #c0c9ce in light mode and #6f7577 for dark mode, simply for aesthetics and readability when the lines cross over file names. I'll push this update first as a fix, but let me know what you think!

1b7 commented 6 months ago

That sounds great, thanks for implementing this!