search

crashoverride777 / swifty-ads

A Swift library to display Google AdMob ads. GDPR, COPPA and App Tracking Transparency compliant.
MIT License
129 stars 40 forks source link

Delegate as Clousure #29

Closed pvn-anh-pham closed 4 years ago

pvn-anh-pham commented 4 years ago

This project is good to go but it lack some feature since integrating ad cleverly will increase revenue also. This is my suggestion:

  1. implement delegate of admob(interstitial & reward) as clousure, make it most handy as it can
  2. option to add the banner below the safe area

Great!

crashoverride777 commented 4 years ago

Hey,

thank you for your comment. I have actually removed the delegate and replaced it with closures for the upcoming v11 version (see develop branch). Also good idea about the banner ads ignoring the safe area, I will add this feature as well in v11. Thanks I am planning to release this very soon.

crashoverride777 commented 4 years ago

Hey,

I will be releasing version 11 with closures today or latest tomorrow. I need to double check some GDPR stuff and than I will push the update.