crashtheparty / EnchantmentSolution

Enchantment plugin for Custom Enchantments.
15 stars 14 forks source link

Merged items only give one of item when picked up #121

Open astirling opened 3 years ago

astirling commented 3 years ago

When items that are merged (e.g. breaking sugar cane or bamboo) are picked up, the player is only receiving one of the item and not the total of items that were merged.

Debug.yml is attached. debug.zip

Steps to reproduce the behavior:

  1. Go to any 3 tall sugarcane or more than 2 tall bamboo stalk
  2. Break the 2nd from bottom piece to harvest it and all the blocks above it
  3. The sugar cane/bamboo will merge while falling
  4. When merged item is picked up you only receive one of the item instead of multiple

Expected behavior It is expected that the player receives all the items from the harvest. e.g. from an 8 high bamboo stalk, the player receives 7 bamboo, not 1

Screenshots N/A

Additional context I narrowed the issue to this plugin and it's dependency by removing them from my test server and performing the reproduction steps described above and got expected behavior. I then reinstalled this plugin and it's dependency and the issue returned.

crashtheparty commented 3 years ago

Is it possible to send a video of this happening? Trying with just CrashAPI and EnchantmentSolution does not show any conflicts with this.

astirling commented 3 years ago

Okay this video is harvesting with Enchantment Solution and CrashAPI installed (v2.4.3.2 and v1.0.7 respectively) https://youtu.be/1Ak-E1PirME

This video is harvesting with the plugins removed https://youtu.be/hloRBbfMbuY

crashtheparty commented 3 years ago

Just tried it on your own server and I didn't see any issues.

astirling commented 3 years ago

Because I'm using an older version. Why would I have a broken version on my live servers? The issue came about when crashapi became a dependency.

crashtheparty commented 3 years ago

Which version are you using live?

astirling commented 3 years ago

We're using version 2.3.26 on our Skyblock server