Update?

[dsobirk]

This package looks fantastic. It seems to use the 1.2.0-cr3 of crash, will it be updated?

Regards D

[vietj]

I am not the maintainer of this plugin and I don't have the skills to do it. If you think you have the skills for it for doing it, it would be very nice to try at least.

Julien

[jaetzold]

Oh, i did not notice that an update was in order, sorry. I will look into it in the next few days.

[dsobirk]

Thanks for looking into this. I was thinking the latest version, any reason not to?

Let me know if I can be of any assistance

/D

On Tue, May 28, 2013 at 8:41 AM, Stephan Jaetzold notifications@github.comwrote:

@vietj https://github.com/vietj Which version do you think should it depend on? 1.2.0?

— Reply to this email directly or view it on GitHubhttps://github.com/crashub/grails/issues/2#issuecomment-18533686 .

[jaetzold]

o.k. I'll use 1.2.5 then.

[jaetzold]

@vietj It seems that with version 1.2.5 the sshd does not start anymore. After looking at SpringBootstrap i can see that the discovery and initialization of some plugins has changed. I suspect it might have something to do with that.

With version 1.2.0-cr3 i basically did nothing else than create an Instance of SpringWebBootstrap and set the config to [ 'crash.vfs.refresh_period': 1, 'crash.ssh.port': 2000, 'crash.telnet.port': 5000, 'crash.auth': 'simple', 'crash.auth.simple.username': 'admin', 'crash.auth.simple.password': 'admin' ]

This would start up the shell and get the sshd to listen on port 2000. Is there something else required now?

[vietj]

it should work like before. I'm looking a bit at the plugin and I don't see what would make this fail...

[vietj]

there is this change that may have changed something : https://github.com/crashub/crash/commit/6ad6e07d1eab8f0ed25fe9ac6a256484029052fc

[jaetzold]

I just tried with releases before 1.2.5 It starts with 1.2.0-cr6 but not anymore with 1.2.0.-cr7 I did change the dependency from cmdline to cli and renamed packages in imports already. But that seems not to be enough. And i wonder whether it has to do with that package at all because the connection to the ssh port already fails.

[jaetzold]

2013-05-28 12:26:55,696 [localhost-startStop-1] INFO ssh.SSHPlugin - Could not boot SSHD due to missing due to missing port configuration

[vietj]

it looks like a configuration problem, here is the current Spring configuration, how does it compare to you ?

https://github.com/crashub/crash/blob/master/shell/packaging/src/main/spring/WEB-INF/spring.xml

[jaetzold]

It has something to do with a change in how the properties are parsed.

If i set the config with this: SpringWebBootstrap.config = [ 'crash.ssh.port': 2000, 'crash.auth': 'simple', 'crash.auth.simple.username': 'admin2', 'crash.auth.simple.password': 'admin2' ]

I get the following logging:

2013-05-28 13:15:31,709 [localhost-startStop-1] INFO plugin.PluginManager - Loaded plugin Plugin[type=SSHPlugin,interface=SSHPlugin] 2013-05-28 13:15:31,712 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth.simple.username=admin2 from properties 2013-05-28 13:15:31,712 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth.simple.password=admin2 from properties 2013-05-28 13:15:31,713 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth=simple from properties 2013-05-28 13:15:31,719 [localhost-startStop-1] INFO ssh.SSHPlugin - Could not boot SSHD due to missing due to missing port configuration 2013-05-28 13:15:31,719 [localhost-startStop-1] INFO plugin.PluginManager - Initialized plugin Plugin[type=SSHPlugin,interface=SSHPlugin]

Notice, that the ssh.port property never gets configured. If i don't set any config i get

2013-05-28 13:35:42,482 [localhost-startStop-1] INFO plugin.PluginManager - Loaded plugin Plugin[type=SSHPlugin,interface=SSHPlugin] 2013-05-28 13:35:42,485 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth.simple.username=admin from properties 2013-05-28 13:35:42,485 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth.simple.password=admin from properties 2013-05-28 13:35:42,485 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property ssh.port=2000 from properties 2013-05-28 13:35:42,486 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth=simple from properties 2013-05-28 13:35:42,494 [localhost-startStop-1] INFO ssh.SSHPlugin - Booting SSHD 2013-05-28 13:35:42,886 [localhost-startStop-1] INFO term.SSHLifeCycle - About to start CRaSSHD 2013-05-28 13:35:43,008 [localhost-startStop-1] INFO term.SSHLifeCycle - CRaSSHD started on port 2000 2013-05-28 13:35:43,008 [localhost-startStop-1] INFO plugin.PluginManager - Initialized plugin Plugin[type=SSHPlugin,interface=SSHPlugin]

So now, the port is configured and SSHD is started. If the numeric property for the port is set as String it gets configured as well: SpringWebBootstrap.config = [ 'crash.ssh.port': '2001', 'crash.auth': 'simple', 'crash.auth.simple.username': 'admin2', 'crash.auth.simple.password': 'admin2' ]

2013-05-28 13:40:02,522 [localhost-startStop-1] INFO plugin.PluginManager - Loaded plugin Plugin[type=SSHPlugin,interface=SSHPlugin] 2013-05-28 13:40:02,524 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth.simple.username=admin2 from properties 2013-05-28 13:40:02,525 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth.simple.password=admin2 from properties 2013-05-28 13:40:02,525 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property ssh.port=2001 from properties 2013-05-28 13:40:02,525 [localhost-startStop-1] INFO spring.SpringWebBootstrap - Configuring property auth=simple from properties 2013-05-28 13:40:02,534 [localhost-startStop-1] INFO ssh.SSHPlugin - Booting SSHD 2013-05-28 13:40:02,947 [localhost-startStop-1] INFO term.SSHLifeCycle - About to start CRaSSHD 2013-05-28 13:40:03,009 [localhost-startStop-1] INFO term.SSHLifeCycle - CRaSSHD started on port 2001 2013-05-28 13:40:03,009 [localhost-startStop-1] INFO plugin.PluginManager - Initialized plugin Plugin[type=SSHPlugin,interface=SSHPlugin]

One could argue, that it is expected that the port is given as String because SpringWebBootstrap.config is of type Properties which should not contain keys or values other than String. In this light i'm surprised it worked before.

But at least i now know what to do to get it working again.

[vietj]

which layer is the cause of this ? CRaSH or Spring ?

[jaetzold]

I don't know for sure. But i don't see where Spring really does anything with the properties aside from passing them into the config property. Did you change anything spring related between 1.2.0-cr6 and -cr7?

[vietj]

I can't see anything like this.

[jaetzold]

@dsobirk I just published an updated version of the plugin that is based on crash 1.2.5. If you have any problems with the new release, please don't hesitate to make me aware of them. Sorry for the delay of this update.

[vietj]

I just released yesterday a new crash 1.2.6 , the upgrade from 1.2.5 should be seamless. It fixes a couples of nasty bugs with command line parsing.

[jaetzold]

Updated the plugin again. It now depends on 1.2.6.

[dsobirk]

Thanks for updating this, much appreciated

On Mon, Jun 3, 2013 at 9:56 AM, Stephan Jaetzold notifications@github.comwrote:

Updated the plugin again. It now depends on 1.2.6.

— Reply to this email directly or view it on GitHubhttps://github.com/crashub/grails/issues/2#issuecomment-18826628 .

[vietj]

Nice, can we do some noise about it ?

[jaetzold]

The plugin update gets automatically tweeted by @grailsplugins

[vietj]

going to RT thanks!