search

crate-ci / azure-pipelines

Easy continuous integration for Rust projects with Azure Pipelines
MIT License
88 stars 24 forks source link

Don't even show coverage step when not configured #1

Closed jonhoo closed 5 years ago

jonhoo commented 5 years ago

Coverage is ... complicated ... currently, because of a bunch of restrictions that Azure Pipelines places on us. In particular, we don't have access to the value of variables in templates, among many other things. This is the reason why we delay deciding whether or not to run coverage all the way until in the very same job. Making it work any other way would require fixes to https://github.com/MicrosoftDocs/vsts-docs/issues/4841, https://github.com/MicrosoftDocs/vsts-docs/issues/4466, and https://developercommunity.visualstudio.com/content/problem/642219/setting-output-variable-when-multiple-stages-share.html.

However, there Is one thing we can do better -- don't include the coverage stage if codecov_token isn't even set.

jonhoo commented 5 years ago

Fixed in 41f142e4f0e7a901945443cfeeeeea6e7ad3973e