search

crate-ci / azure-pipelines

Easy continuous integration for Rust projects with Azure Pipelines
MIT License
88 stars 24 forks source link

Should we verify minimal dependency versions #25

Closed epage closed 4 years ago

epage commented 5 years ago

cargo has an unstable flag to calculate dependencies using the minimum rather than the maximum version. This verifies that Cargo.tomls are not stale.

epage commented 5 years ago

The downside is the brittleness of dependencies if they aren't also verifying it.

jonhoo commented 5 years ago

I think this should be an opt-in stage. Not sure what Rust version it should be run on (does it require nightly atm?).

epage commented 5 years ago

I think you can use unstable flags without nightly but I'm unsure. I at least do it with libtest's json output.

epage commented 5 years ago

As for best practices, I am unsure. I've seen discussions around this but haven't adopted it myself (yet). I've been tempted to adopt it due to minrust issues.

jonhoo commented 5 years ago

Relevant: https://github.com/rust-lang-nursery/api-guidelines/issues/123

jonhoo commented 4 years ago

Closing this in favor of #78.