crate-ci / azure-pipelines

Easy continuous integration for Rust projects with Azure Pipelines

MIT License

88 stars 24 forks source link

Allow tweaking Rust version for coverage job #37

Closed djc closed 5 years ago

djc commented 5 years ago

rustc has been broken for a while for Quinn's coverage. This has recently been fixed on master, so it would be nice if I can tweak the config to have coverage run on nightly instead of stable.

epage commented 5 years ago

Looks like there is a latest-nightly tag we could take advantage of.

Questions to resolve for this

How to expose this in coverage.yml template? Do we accept the docker information as a parameter? Accept the rusttoolchain and map that to docker images?
Should this be exposed in stages.yml template or is it too specialized, making the usability worse for the simple cases?

@jonhoo, thoughts?

djc commented 5 years ago

I was thinking just as a parameter. My particular use may indeed be quite niche, but I could imagine that nightly-only projects (for example, anyone working on their async/await stuff right now) would still be interested in coverage data, so just defaulting to stable doesn't seem like a great option either.

jonhoo commented 5 years ago

42 adds a `nightly_coverage` parameter to `stages`, and `nightly` parameter to `coverage` :)

crate-ci / azure-pipelines

Allow tweaking Rust version for coverage job #37

42 adds a nightly_coverage parameter to stages, and nightly parameter to coverage :)

42 adds a `nightly_coverage` parameter to `stages`, and `nightly` parameter to `coverage` :)