search

crate-ci / azure-pipelines

Easy continuous integration for Rust projects with Azure Pipelines
MIT License
90 stars 24 forks source link

cargo-check fails on workspaces due to --no-default-features #66

Closed qdot closed 4 years ago

qdot commented 5 years ago

--no-default-features errors on workspace projects, meaning the cargo-check step will fail for any workspace project. It'd be nice to have a parameter to turn this build check off.

See https://github.com/rust-lang/cargo/issues/5015

jonhoo commented 5 years ago

@epage I think more and more that we need either a workspace flag, or a separate workspace stage :'(

qdot commented 5 years ago

I submitted a small workaround PR for now. It could be used for configuring a workspace stage if you do go that direction.

epage commented 5 years ago

@epage I think more and more that we need either a workspace flag, or a separate workspace stage :'(

Are all crates safe with "no-default-features`? Would we need it configurable anyways, like all-features?

jonhoo commented 4 years ago

See also https://github.com/rust-lang/cargo/issues/7727