crate-ci / cargo-release

Cargo subcommand `release`: everything about releasing a rust crate.
Apache License 2.0
1.33k stars 112 forks source link

What's the minimal rust version? #286

Closed Endle closed 3 years ago

Endle commented 3 years ago

I'm using rust 1.49.0

When installing this package, I hit E0658

$ cargo install cargo-release

error[E0658]: use of unstable library feature 'str_split_once': newly added
   --> /home/lizhenbo/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/cargo-release-0.16.3/src/version.rs:113:63
    |
113 |             if let Some((alpha, numeric)) = self.pre.as_str().split_once(".") {
    |                                                               ^^^^^^^^^^
    |
    = note: see issue #74773 <https://github.com/rust-lang/rust/issues/74773> for more information

What's the minimal rust version for cargo-release?

Thank you

epage commented 3 years ago

1.52.

I recommend checking CI as the definitive in this. Even if we document it somewhere, it is likely to be missed as we update CI.

Granted, that can be confusing because we have a stale travis file that we aren't using.

sunng87 commented 3 years ago

Let me remove that travis config to avoid confusion.

sunng87 commented 3 years ago

Fixed in 6b731bb