search

crate-ci / cargo-release

Cargo subcommand `release`: everything about releasing a rust crate.
Apache License 2.0
1.33k stars 112 forks source link

Please follow `package.publish` settings in Cargo.toml #733

Closed zhengcan closed 10 months ago

zhengcan commented 10 months ago

As introduced in The Cargo Book, "The publish field can be used to prevent a package from being published to a package registry (like crates.io) by mistake, for instance to keep a package private in a company."

[package]
# ...
publish = false

Currently, cargo release will bump version for these publish-forbidden crates. It doesn't make sense. Please ignore these publish-forbidden crates, and don't publish them.

epage commented 10 months ago

If we are publishing them, that is a bug. If we are releasing them, then that is not.

We had a request to default release to package.publish but after doing so, we got a lot of feedback about how undesirable it was and reverted.

You can disable all release processes for your package via the config.

zhengcan commented 10 months ago

Ok. I'll close this issue. THX