search

crate-ci / cargo-release

Cargo subcommand `release`: everything about releasing a rust crate.
Apache License 2.0
1.33k stars 112 forks source link

Breaking CI #752

Closed nbittich closed 8 months ago

nbittich commented 8 months ago

Hello,

seems my CI is broken:

   Compiling cargo-release v0.25.4
error[E0433]: failed to resolve: could not find `ser` in `toml_edit`
  --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-release-0.25.4/src/error.rs:38:32
   |
38 | process_error_from!(toml_edit::ser::Error);
   |                                ^^^ could not find `ser` in `toml_edit`
   |
help: consider importing one of these items
   |
1  + use serde::ser;
   |
1  + use toml::ser;
   |
help: if you import `ser`, refer to it directly
   |
38 - process_error_from!(toml_edit::ser::Error);
38 + process_error_from!(ser::Error);

I tried to reproduce (successfully) locally using docker:

docker run --rm -it rust:1.75
cargo install cargo-release
epage commented 8 months ago

Newly released v0.25.5 should fix this. We weren't enabling a feature, relying on another dependency to do so. A breaking change meant two different versions of that dependency are now being used, making it so the feature is no longer enabled.