search

crate-ci / cargo-release

Cargo subcommand `release`: everything about releasing a rust crate.
Apache License 2.0
1.31k stars 109 forks source link

Git User/E-mail is required even if --no-push option is given when running on GitHub runner. #765

Closed psandana closed 6 months ago

psandana commented 6 months ago

Summary

When executing cargo release using a version (not a particular step), it requires that Git User/E-mail is set even if --no-push and --no-tag flags are passed. This is a common scenario on a GitHub pipeline, on which e-mail is not set or invalid.

cargo release 1.0.0 -p package --registry Registry --execute --no-confirm --no-push --no-tag

Expected

Previous command should work even if Git User/E-mail is not set, as they are only needed for pushing to remotes

epage commented 6 months ago

User name and email are also needed for committing which cargo release does.

Note that the requirement is coming from git, and not cargo-release.

psandana commented 6 months ago

Didn't noticed that it was complaining by the commit. Thanks for the notice. Closing this issue as invalid one.