RFE: check allowed authors

crate-ci / committed

Nitpicking commit history since beabf39

Apache License 2.0

101 stars 6 forks source link

RFE: check allowed authors #353

Open scop opened 10 months ago

scop commented 10 months ago

A check for allowed authors would be nice, for example so that projects wanting committers to use their project/organization related e-mail addresses for commits could check that.

I think a regex config option and related (inverse) matching similar to ignore_author_re could be used for this.

epage commented 10 months ago

Mind writing up a proposed schema with an example of what data it would allow/disallow and what that message would look like?

scop commented 10 months ago

Mini-PR in https://github.com/crate-ci/committed/pull/354 -- feel free to reuse that and the associated branch for the implementation if you're taking this on.

The regex would be matched against the commit author (whole string), just like ignore_author_re.
If the regex matches, all good, no messages.

If it does not match, would cause an error with a message like

Commit author `{}` does not match allowed regular expression `{}`

epage commented 9 months ago

Seems reasonable if someone wants to implement it.