crate-ci / committed

Nitpicking commit history since beabf39
Apache License 2.0
101 stars 6 forks source link

Config file not supported? #360

Closed BenLeadbetter closed 8 hours ago

BenLeadbetter commented 9 months ago

Hi, nice tool!

I had a poke around and found the --config and --dump-config arguments to the committed exec. I tried out the following:

committed --dump-config .committed-config

And set my .pre-commit-config to read from this file:

- repo: https://github.com/crate-ci/committed
  rev: v1.0.20
  hooks:
  - id: committed
    args: [--config, .committed-config]

However, this makes the hook fail with the following error:

failed to parse revision specifier - Invalid pattern '.git/COMMIT_EDITMSG'; class=Invalid (3); code=InvalidSpec (-12)

Is this workflow not supported? Is there another way to specify configuration via my .pre-commit-config file? From the output of --dump-config, it looks like there's some nice configuration options there which I would love to try out.

Thanks

epage commented 9 months ago

Running directly, it works.

Something must be going wrong with pre-commit but unsure what.

epage commented 8 hours ago

Without further information on a reproduction case, I'm going to go ahead and close this