search

crate-ci / committed

Nitpicking commit history since beabf39
Apache License 2.0
101 stars 6 forks source link

Autosquash Improvements #394

Closed JP-Ellis closed 3 days ago

JP-Ellis commented 4 days ago

There are three main changes here:

  1. Expanded the autosquash prefixes from just fixup! to now include squash! and amend!. This ensures better compliance with the Git docs in git-rebase.
  2. To go with (1), aliased fixup with autosquash. This was done both in the CLI and in the config. Eventually, it may be worth deprecating fixup in favour of autosquash; however, I am leaving that as a "future change".
  3. When autosquash commits are allowed and an autosquash commit is detected, the remaining checks at done on the remainder of the commit message.

I understand that the change from "fixup" to "autosquash" might be a bit of a big change; however, this should be all backwards compatible. Happy to revise the PR if this is a step too far.

Resolves #392

epage commented 3 days ago

This PR is listed as making 3 changes but it does so in 2 commits. Please be sure to make your commits atomic. The first two changes are different enough from the third, that really, this should be at least 2 PRs.

JP-Ellis commented 17 hours ago

Replaced by: