crate-ci / committed

Nitpicking commit history since beabf39
Apache License 2.0
103 stars 7 forks source link

feat: strip prefix #397

Open JP-Ellis opened 1 month ago

JP-Ellis commented 1 month ago

If fixups are allowed, then the remainder of the commit message ought to either be either a previous commit's subject line, or a hash:

If a commit message starts with "squash! ", "fixup! " or "amend! ", the remainder of the subject line is taken as a commit specifier, which matches a previous commit if it matches the subject line or the hash of that commit.

So we can either:

  1. Assume that previous commit's subject line was previously validated and do nothing further; or,
  2. Validate the remainder of the commit's subject line as is.

This specific implementation opts for the latter.

Resolves #392

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10936396451

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/committed/src/checks.rs 0 5 0.0%
<!-- Total: 0 5 0.0% -->
Files with Coverage Reduction New Missed Lines %
crates/committed/src/checks.rs 1 2.07%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10906075176: -0.06%
Covered Lines: 24
Relevant Lines: 440

💛 - Coveralls