remove asserts that could leak timing information (credits to @pornin) - Githubissues

crate-crypto / Ed448-Goldilocks

25 stars 12 forks source link

remove asserts that could leak timing information (credits to @pornin) #31

Closed conradoplg closed 1 year ago

conradoplg commented 1 year ago

Closes #30 by simply removing the asserts.

I tried to expand the comment in scalar.rs to justify why borrow would never be 1, but got stuck at trying to find a case where carry would be 1 in the first place... So I just gave up on that for now.