search

crate-crypto / rust-eth-kzg

Apache License 2.0
13 stars 5 forks source link

Error with `erasure_codes` benchmark #84

Closed jtraglia closed 3 months ago

jtraglia commented 3 months ago 
Running benches/benchmark.rs (target/release/deps/benchmark-5e0ad2e17c19d295)
thread 'main' panicked at erasure_codes/benches/benchmark.rs:34:31:
index out of bounds: the len is 8192 but the index is 13184
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p crate_crypto_internal_peerdas_erasure_codes --bench benchmark`
kevaundray commented 3 months ago

I can look into this -- I don't think it makes sense to run benchmarks in CI since they take forever, so this might be a "way of life"

The GitHub-actions-benchmarks might be a good alternative in the future

kevaundray commented 3 months ago

Should be fixed in #86 and we can re-evaluate the benchmarks in #62!

kevaundray commented 3 months ago

Closing since #86 is merged!