search

crate-crypto / x448

9 stars 5 forks source link

Add Zeroize #1

Open kevaundray opened 4 years ago

anonion0 commented 2 years ago

I added Zeroize support, but it first requires support for it in the ed448-goldilocks crate as well: PR

Should you decide to merge that and release a new ed448-goldilocks crate version, I'll make a PR here.

kevaundray commented 2 years ago

Thank you very much for this. I've merged your other PR and have released a new version 0.8.3 with the changes to crates.io

anonion0 commented 2 years ago

w.r.t. the zeroing of stack variables containing secret data (e.g. during curve point multiplication): I took a quick glance at the x25519-dalek and curve25519-dalek crates to see how they handle it. It seems as they currently don't do anything of the sort.

Some further work is probably needed.

kevaundray commented 2 years ago

Oh right, I believe there was an issue where it was discussed, but I cannot find it right now