add Zeroize support for SharedSecret and Secret - Githubissues

crate-crypto / x448

9 stars 5 forks source link

add Zeroize support for SharedSecret and Secret #5

Closed anonion0 closed 2 years ago

anonion0 commented 2 years ago

Note that I also made SharedSecret a new type instead of a type alias, for two reasons:

It is a slightly safer API with minimal additional code
It allows SharedSecret to be zeroized on drop without the overhead of doing the same for PublicKey

I also just noted that Secret::as_scalar() calls Scalar::from_bytes() and thus creates a copy. I didn't add zeroize support for Scalar (yet).

kevaundray commented 2 years ago

LGTM