search

crate-py / rpds

Python bindings to the Rust rpds crate for persistent data structures
https://rpds.readthedocs.io/
MIT License
41 stars 14 forks source link

Fix hashing overflow issues (#86) #87

Closed FlickerSoul closed 2 weeks ago

FlickerSoul commented 3 months ago

This PR fixes overflow errors during hashing persistent data structures.

Julian commented 3 months ago

Nice! Any chance you also might take a stab at the suggestion to run with --profile=dev in CI? I'm not 100% sure what it does (so a good first step is probably double checking) but if we don't add it, it's obviously likely we could accidentally add some other thing which trips it.

FlickerSoul commented 3 months ago

It looks like the arguments are passed to maturin and then to cargo during building rpds. See here and here. The dev profile enables the overflow check and that's why we see the errors in the issue. It could be helpful in terms of debugging and producing extra information, I think?

Julian commented 3 months ago

From that page it would seem like we should run with --profile=test, which implies dev.

FlickerSoul commented 3 months ago

Yes I think test would make more sense. I can modify the CI to do that :)

Julian commented 2 months ago

@FlickerSoul let me know if you're still up for making the CI change! (Thanks again for your work so far)