search

crate-workbench / meltano-target-cratedb

A Singer target / Meltano loader for CrateDB, built with the Meltano SDK, and based on the Meltano PostgreSQL target.
MIT License
0 stars 0 forks source link

Tests: Make `test_anyof` work #12

Closed amotl closed 10 months ago

amotl commented 10 months ago

About

Just fixes a test case after recent changes.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (6b44b8d) 82.12% compared to head (6c9ea1f) 85.00%.

:exclamation: Current head 6c9ea1f differs from pull request most recent head dbf64ad. Consider uploading reports for the commit dbf64ad to get more accurate results

Files Patch % Lines
target_cratedb/sqlalchemy/vector.py 72.22% 15 Missing :warning:
target_cratedb/sinks.py 37.50% 10 Missing :warning:
target_cratedb/connector.py 83.33% 6 Missing :warning:
target_cratedb/tests/test_standard_target.py 94.54% 6 Missing :warning:
target_cratedb/sqlalchemy/patch.py 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12 +/- ## ========================================== + Coverage 82.12% 85.00% +2.87% ========================================== Files 7 7 Lines 677 680 +3 ========================================== + Hits 556 578 +22 + Misses 121 102 -19 ``` | [Flag](https://app.codecov.io/gh/crate-workbench/meltano-target-cratedb/pull/12/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crate-workbench) | Coverage Δ | | |---|---|---| | [main](https://app.codecov.io/gh/crate-workbench/meltano-target-cratedb/pull/12/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crate-workbench) | `85.00% <83.89%> (+2.87%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crate-workbench#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.