search

crate / activerecord-crate-adapter

Ruby on Rails ActiveRecord adapter for CrateDB
Apache License 2.0
26 stars 7 forks source link

Update to Ruby 3 #28

Open amotl opened 9 months ago

amotl commented 9 months ago

Hi there,

apparently, this repository is still on Ruby 2.

https://github.com/crate/activerecord-crate-adapter/blob/f58fe3e8ec0fb3a993d535718b839e0bd1227851/.github/workflows/tests.yml#L26-L28

Coming from https://www.ruby-lang.org/en/downloads/releases/, I think it is safe to assume Ruby 2 is a thing of the past, and the repository should be upgraded to work with recent versions of Ruby 3? wdyt, @hammerhead?

With kind regards, Andreas.

NB: This may also help to make GH-26 conclude without needing to bring in old Bundler releases still working on Ruby 2 in one way or another.

hammerhead commented 8 months ago

Hi,

Yes, upgrading to Ruby 3 totally makes sense. I think the currently used activerecord version doesn't support Ruby 3 yet, so we need to upgrade to a (slightly) more recent activerecord version first, before bumping Ruby itself.

Just opened #29 to at least fix the build right now on 2.7.

amotl commented 8 months ago

Thanks. Let me also cite your other discovery here:

The usage of BigDecimal.new within activerecord itself currently blocks further Ruby version upgrades. As per that link above, Ruby 2.7 is the latest version still supporting BigDecimal.new.

-- https://github.com/crate/activerecord-crate-adapter/pull/29#discussion_r1494324392