crate / cloud-docs

Documentation for CrateDB Cloud.
https://crate.io/docs/cloud/
Apache License 2.0
0 stars 1 forks source link

Images using scale are stretched #43

Closed msbt closed 5 months ago

msbt commented 9 months ago

Documentation feedback

The images on this page that have :scale: 50% via https://github.com/crate/cloud-docs/blob/main/docs/tutorials/edge/introduction.rst?plain=1#L310-L312 (and probably all others that use this) are skewed/stretched. I thought that bug was fixed, but apparently it's not. There's a card on the website board which describes possible solutions, please ping me if/when you have bandwidth for that @amotl @matkuliak


amotl commented 9 months ago

Hi. Currently, I have no significant bandwidth. What happens when removing :scale: 50% altogether?

msbt commented 9 months ago

@amotl it will just use only alt + source, like on the first image <img alt="CrateDB Cloud sign-in screen" src="../_images/start.png">

width and height attributes would be nice so we don't have layout shifts, but I would prefer those over stretched images ;)

amotl commented 9 months ago

Is this related? / Can this be used to solve the problem better?

msbt commented 9 months ago

Ah yes, it might actually, but since there's no proper demo or documentation I can't really tell, but that extension could solve more than one problem!

amotl commented 9 months ago

Did you also have a look whether https://myst-parser.readthedocs.io/ can do more than Sphinx itself?

matkuliak commented 9 months ago

Hello. Happy to look into this with priority when I come back (thursday).

msbt commented 5 months ago

@matkuliak any chance you had time to check this out? Or what is our general plan with the docs and the other template you started building?

matkuliak commented 5 months ago

Hi @msbt. I submitted a patch, where I updated the pics and removed the :scale: 50%, that should help for now.

msbt commented 5 months ago

thanks @matkuliak, will close this for now then