search

crate / crate-dbal

Doctrine Database Access Layer for Crate.IO
Apache License 2.0
16 stars 10 forks source link

Add compatibility with PHP 8.0 #105

Closed amotl closed 3 years ago

amotl commented 3 years ago

Hi there,

PHP 8.0.1 has been released and PHP 8.1.x is in the making. We might want to follow that.

With kind regards, Andreas.

amotl commented 3 years ago

Now that crate-pdo version 2.0.0 has been released, we can look into adding PHP8 support here.

amotl commented 3 years ago

Thanks for working on #111, @alexander-schranz. [1] gives some first insights into what has to be made compatible.

Argument 1 passed to Doctrine\DBAL\Connection::ensureForwardCompatibilityStatement() must implement interface Doctrine\DBAL\Driver\ResultStatement, instance of Crate\PDO\PDOStatement given, called in /home/runner/work/crate-dbal/crate-dbal/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 1314

[1] https://github.com/crate/crate-dbal/runs/2452765877#step:7:17

amotl commented 3 years ago

Same error on #113 with PHP7.4, see [2]. So, this is not specific to PHP8, right?

[2] https://github.com/crate/crate-dbal/runs/2453058434#step:7:17

alexander-schranz commented 3 years ago

Looks for me like it is still a Crate\PDO\PDOStatement instead of our new set Doctrine\DBAL\Driver\PDO\Statement. Not sure what I missed here.

amotl commented 3 years ago

Resolved through #111 by @alexander-schranz. Thanks a stack.