crate / crate-docs-theme

A Sphinx theme for the CrateDB documentation.
https://crate-docs-theme.readthedocs.io/
Apache License 2.0
20 stars 5 forks source link

Attempt to fix the missing `index.html` in canonical URLs #482

Closed msbt closed 7 months ago

msbt commented 7 months ago

Summary of the changes / Why this is an improvement

This should add the missing index.html for canonical URLs (original issue: https://github.com/crate/tech-writing/issues/417#issuecomment-2066746951). Can we do a demo to test thoroughly before going live? Tested locally, but not sure what happens when RTD is trying to add their own code, could be either ignored or this piece overwritten.

Code is borrowed from https://github.com/readthedocs/readthedocs-sphinx-ext/blob/614109c6ad11eaacbcde1040b908967c80b81eba/readthedocs_ext/_templates/readthedocs-insert.html.tmpl#L4-L19

msbt commented 7 months ago

@amotl any idea what's happening there? ;)

amotl commented 7 months ago

Superseded by GH-488.