Closed msbt closed 1 week ago
Excellent stuff, thanks a stack. 💯
For testing the improvements, let's just run another -dev release from this branch, in order to validate the outcome on a few prominent downstream projects?
@amotl thanks, I've compared many of the docs pages and it looks pretty good, but I saw that we'll be having troubles with (at least) the CrateDB reference docs, since various PNGs are transparent and some of the text will will unreadable in dark mode, like here: https://cratedb.com/docs/crate/reference/en/latest/concepts/joins.html#join-types
vs
I'll try to think of a solution
@amotl Ok I checked all docs repositories and the crate one seems to be the only one with such images. I counted 10 of those, so instead of hacking something together, I would just export those with white background and push them in the repo, would that be a viable solution for you as well?
Do what ever sounds viable to you, thanks!
Hi. It looks like https://github.com/crate/crate/pull/16997 has been merged prematurely, without squashing the commits, and without tagging the PR for relevant backports.
Can you squash both commits https://github.com/crate/crate/commit/d297844a423a2ee42f64bccc7ea7c175e28b854c and https://github.com/crate/crate/commit/4143e9afbbc41a4fd2ad64527a7658e0a4480a21 into a single one, and hand it in again, this time against the 5.9 branch? From there, we will need to backport to 5.8, 4.8, and eventually 3.3, maybe with the help of Mergify. Thanks!
Hi. It looks like crate/crate#16997 has been merged prematurely, without squashing the commits, and without tagging the PR for relevant backports.
Can you squash both commits crate/crate@d297844 and crate/crate@4143e9a into a single one, and hand it in again, this time against the 5.9 branch? From there, we will need to backport to 5.8, 4.8, and eventually 3.3, maybe with the help of Mergify. Thanks!
Ah my bad, since I'm not feeling too good, this has to wait until Monday, sorry for that :/
Please take your time, there is no blocker or pressure in here.
@amotl I've reverted the icons.html
changes as you suggested, I guess we can make a dev release now :smile:
Summary of the changes / Why this is an improvement
This PR started off with testing the compatibility of https://github.com/crate/crate-docs-theme/pull/523. I went a little overboard and pulled in more assets from furo, to bring dark mode to live (sorry for the mess in the first commit, but it was just too much to split up because I had to do a lot of testing/back and forth). I checked all the examples and it looks good, not sure how it behaves on a live environment, probably needs a bit of polishing before publishing (e.g. to see how the icons from the guide are working).
Notes: copied over some admonitions from furo to check the complete iconset
wdyt @amotl, too much? ;)
Preview URL: https://crate-docs-theme--546.org.readthedocs.build/en/546/