SQLAlchemy/DDL: Handle `server_default` column schema argument well

crate / crate-python

Python DB API client library for CrateDB, using HTTP.

https://cratedb.com/docs/python/

Apache License 2.0

79 stars 30 forks source link

SQLAlchemy/DDL: Handle `server_default` column schema argument well #556

Closed JanLikar closed 1 year ago

JanLikar commented 1 year ago

Summary of the changes / Why this is an improvement

CrateDB's SQLAlchemy dialect now handles the server_default when generating table DDL.

Fix crate/sqlalchemy-cratedb#106.

Checklist

[x] CLA is signed

JanLikar commented 1 year ago

Other than a suggestion about reStructuredText syntax, and maybe a slight naming change on the test methods, I think it will be good to go.

I applied the fixes and squashed the commits. To be honest, I've been using Markdown so much lately I didn't even realize this is rst, thanks for spotting the issue.

amotl commented 1 year ago

Merged. Thank you again, and have a good weekend.