SQLAlchemy: Ignore SQL's "FOR UPDATE" clause

crate / crate-python

Python DB API client library for CrateDB, using HTTP.

https://cratedb.com/docs/python/

Apache License 2.0

79 stars 30 forks source link

SQLAlchemy: Ignore SQL's "FOR UPDATE" clause #584

Closed surister closed 11 months ago

surister commented 11 months ago

Summary of the changes / Why this is an improvement

Pretty straightforward, now queries like select(table).with_for_update() will not generate a FOR UPDATE statement.

Resolves crate/sqlalchemy-cratedb#95.

Checklist

[x] Link to issue this PR refers to (if applicable):
[x] CLA is signed

amotl commented 11 months ago

Dear @surister,

after bringing in crate/crate-python#582 and crate/crate-python#583, I am going to wrap this up, if you don't have any objections. Users are waiting for another release, and my intention was only to bring in a few small maintenance updates and little improvements like this.

Your contribution was a perfect fit for that, and arrived just in time. Thank you again.

With kind regards, Andreas.