crate / crate-python

Python DB API client library for CrateDB, using HTTP.
https://cratedb.com/docs/python/
Apache License 2.0
79 stars 30 forks source link

Remove SQLAlchemy dialect #616

Closed amotl closed 2 months ago

amotl commented 2 months ago

About

This patch removes the SQLAlchemy dialect from the DB API driver. It lives in the sqlalchemy-cratedb repository now.

Details

This branch will be used for testing purposes right away, and must only be merged when sqlalchemy-cratedb is ready, i.e. when it is considered to be good enough to not cause too much friction for downstream users.

References

/cc @karynzv, @hlcianfagna, @hammerhead, @tomach, @proddata, @surister, @seut, @simonprickett

amotl commented 2 months ago

Status Report

[...] must only be merged when sqlalchemy-cratedb is ready, i.e. when it is considered to be good enough to not cause too much friction for downstream users.

sqlalchemy-cratedb has been slotted into a few downstream projects already, and CI runs on them are succeeding across the board.

PyPI Downloads

The amount of traffic on that dependency is 2k/month in June 2024 already, so we are considering it stable enough for a switchover, paired with corresponding instructions how to migrate from crate.client.sqlalchemy.

Request for Review

Please also review the relevant announcement notice on the community forum ^1 and the corresponding migration notes on the documentation ^2. If you can come up with any improvements, please just go ahead and edit the article inline on Discourse, or submit a PR for the migration notes. /cc @simonprickett