search

crate / crate-qa

CrateDB Quality Assurance
4 stars 1 forks source link

Remove stock JDBC client tests #278

Closed mfussenegger closed 9 months ago

mfussenegger commented 11 months ago

The integration tests in the crate repo already use the stock PostgreSQL JDBC client.

matriv commented 11 months ago

I'd say to not remove those, as very recently helped us identify an issue: https://github.com/crate/crate/pull/14754. What do you think?

matriv commented 9 months ago

Apologies, but I don't agree to remove the tests from here, crate-qa CI is something that we monitor closely and indicates possible issues when we change things in CrateDB. Whereas cratedb-examples has a completely different purpose, it's to show basic usage of various integrations and it's not connected to CrateDB dev lifecycle.

amotl commented 9 months ago

All right. So, let's close this PR and maybe let's also add some Dependabot configurations to the QA tests here, so that errors like currently happening at GH-288 can be caught earlier in the future?

Do you have any strong objections, @mfussenegger?

matriv commented 9 months ago

Do you have any strong objections, @mfussenegger?

Yep, let's here other's opinion on this one before closing, thx!

mfussenegger commented 9 months ago

The idea would've been to extend the tests in crate/crate to fill in any gaps. Having more tests is good, having redundant test cases not so much.

But probably makes sense to keep it here, given that JdbcMetaDataTest is very client specific.

matriv commented 9 months ago

Totally agree to try to move the stuff that makes sense to crate/crate repo and here only have smoke tests if necessary.