crate / docker-crate

Source repository for the official CrateDB Docker image
https://registry.hub.docker.com/_/crate/
Apache License 2.0
49 stars 22 forks source link

Remove Healthcheck #151

Closed autophagy closed 5 years ago

autophagy commented 5 years ago

@chaudum Do you know of a straightforward way of testing the usecase with SSL enabled? As far as I know, to get SSL working on the docker container would require much more configuration than just enabling SSL. Thoughts?

chaudum commented 5 years ago

Testing HTTPS is not necessarily required IMO; we should be able to rely on --insecure to work as expected.

mfussenegger commented 5 years ago

Could we instead of having a HTTP level check do a check on TCP level? E.g. with socat / nc?

autophagy commented 5 years ago

@mfussenegger something like

printf "GET / HTTP/1.1\r\n\r\n" | nc localhost 4200 | grep HTTP/1.1 | awk {'print $2'}

? Though, if our healthcheck gets complicated, I'd rather put it into a healthcheck.sh.