search

crate / docker-crate

Source repository for the official CrateDB Docker image
https://registry.hub.docker.com/_/crate/
Apache License 2.0
49 stars 22 forks source link

Remove buildout, which is only used to run the itests #166

Closed marregui closed 4 years ago

marregui commented 4 years ago

This script was raising -> "TypeError: 'Version' object is not iterable" in the context of checking whether any of the component parts in the version instance (major, minor, fix) was prefixed with a '', in which case the version was not considered final (unless the part had the str 'final' in it). Having checked, none of the versions contain a '' anyways, thus they always seem to be final. The check is redundant.

marregui commented 4 years ago

I would prefer that a crate/crate:test tag did exist in out images repo

mfussenegger commented 4 years ago

Is it really necessary to re-structure the test files like that? I'd have thought that it is enough to add the load_tests method in the individual files (and maybe an empty __init__.py)

marregui commented 4 years ago

No, it has been a case of me learning about running unittests, using zope-testrunner, and general standards on tests layout in python. Now I know