crate / mlflow-cratedb

MLflow adapter for CrateDB.
Apache License 2.0
1 stars 1 forks source link

Observations on updating to MLflow 2.8 #50

Closed amotl closed 10 months ago

amotl commented 10 months ago

About

MLflow 2.8.0 was released three days ago. Dependabot told us about it on behalf of GH-42, but the software tests are failing on CI.

Summary

This is a summary about the failing test cases.

FAILED tests/test_tracking.py::TestSqlAlchemyStore::test_log_batch_params_max_length_value - AssertionError: Regex pattern did not match.
 Regex: 'exceeded length'
 Input: "Changing param values is not allowed. Params were already logged='[{'key': 'long param', 'old_value': 
FAILED tests/test_tracking.py::TestSqlAlchemyStore::test_log_param_max_length_value - AssertionError: Regex pattern did not match.
 Regex: 'exceeded length'
 Input: "Changing param values is not allowed. Param with key='blahmetric' was already logged with 
======= 2 failed, 136 passed, 3 skipped, 6 warnings in 279.01s (0:04:39) =======

-- https://github.com/crate-workbench/mlflow-cratedb/actions/runs/6689895692/job/18174227007?pr=42#step:6:1116

amotl commented 10 months ago

About the error shared above, I only have been able to discover those resources, which are still talking about MLflow 1.x.

amotl commented 10 months ago

Aha. A few numbers had to be increased, to raise the same expected error here as beforehand, i.e. it was just about fixing the test cases.

amotl commented 10 months ago

Problem

FAILED tests/test_tracking_issues.py::test_log_model_twice - mlflow.exceptions.MlflowException: (crate.client.exceptions.ProgrammingError) ColumnUnknownException[Column storage_location unknown]

-- https://github.com/crate-workbench/mlflow-cratedb/actions/runs/6721143498/job/18266209126?pr=51#step:6:1058

Thoughts

Column storage_location unknown

That's probably just a missing DDL detail, not carried over properly from the SQLAlchemy-based definition into our SQL-based definition.

Solution

Has been addressed by adding storage_location to the SQL DDL.

amotl commented 10 months ago

We added support for MLflow 2.8, including corresponding adjustments, and documentation.

amotl commented 10 months ago

mlflow-cratedb 2.8.0 has been released.