Dialect: Fix `get_table_names()` reflection method

crate / sqlalchemy-cratedb

SQLAlchemy dialect for CrateDB.

https://cratedb.com/docs/sqlalchemy-cratedb/

Apache License 2.0

3 stars 2 forks source link

Dialect: Fix `get_table_names()` reflection method #10

Closed amotl closed 3 months ago

amotl commented 9 months ago

About

The get_table_names() reflection method did not respect the schema query argument in SQLAlchemy connection URLs. This improvement has been used successfully on a few downstream projects and is known as the inspector patch. This patch brings it to mainline.

References

https://github.com/crate-workbench/cratedb-toolkit/pull/59

Backlog

[x] Add software tests from https://github.com/crate-workbench/cratedb-toolkit/blob/v0.0.2/tests/sqlalchemy/test_patch.py.

codecov-commenter commented 7 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

surister commented 6 months ago

This item is reviewed and the missing things done, we can merge it @amotl

amotl commented 6 months ago

This item is reviewed and the missing things done, we can merge it.

Excellent. Thank you very much. Please note it is a stacked PR, so others need to be merged first, or the branch needs to be set up differently. Otherwise, it will cause a mess at GH-9.

amotl commented 3 months ago

After refreshing this patch, a single test slot is failing, and we don't know why.

-- https://github.com/crate-workbench/sqlalchemy-cratedb/actions/runs/9447156151/job/26018372721?pr=10

Because it is on SQLAlchemy 1.3 only, we can skip corresponding test cases leniently, like exercised in 20443d2131563.

Edit: Fixed with b91188bda44.