search

crate / tsperf

TSPERF Time Series Database Benchmark Suite. Framework for evaluating and comparing the performance of time series databases, in the spirit of TimescaleDB's TSBS.
https://tsperf.readthedocs.io/
Apache License 2.0
5 stars 0 forks source link

Review gist of CrateDB adapter #63

Open amotl opened 4 months ago

amotl commented 4 months ago

Hi there,

we just talked about TSPERF again, because both TSBS and RockBench will no longer be maintained going forward, so TSPERF could be considered as a good alternative.

Can I humbly ask you to evaluate and/or confirm this is the optimal / most-performant way to insert data into CrateDB?

https://github.com/crate/tsperf/blob/666ddfe3a29607231c613b0b523be8dce053ec7e/tsperf/adapter/cratedb.py#L66-L79

With kind regards, Andreas.

/cc @WalBeh, @proddata, @hammerhead, @hlcianfagna

hammerhead commented 4 months ago

According to the documentation, UNNEST is still faster than multi-value statements. But it also says that the HTTP bulk endpoint is comparable to UNNEST:

The advantages are the same as using the UNNEST method:

From that perspective, I think we can use the more common self.cursor.executemany over UNNEST. Which is also what we typically use in production (for Python environments).