search

crater-invoice / crater

Open Source Invoicing Solution for Individuals & Businesses
https://craterapp.com
GNU Affero General Public License v3.0
7.83k stars 1.57k forks source link

Invoice PDF Link returns customers without portal to login page instead of the invoice pdf #814

Open Pazekal90 opened 2 years ago

Pazekal90 commented 2 years ago

Describe the bug Invoice PDF Link returns customers without portal to login page instead of the invoice pdf. The customer has NOT an active portal and the corresponding flag in customer administration is turned off. But nevertheless the user is not getting the pdf by clicking the button in the mail. Instead he is forwarded to the login page. :/

Also have unchecked the "expire" function for invoices. Same result. Forwarded to login page.

mohitpanjwani commented 2 years ago

Hey, are you talking about the invoice link field or the view invoice button which exists by default on the email template.

mohitpanjwani commented 2 years ago

@Pazekal90 Can you please upgrade to latest 6.0.5 and check if you can reproduce the issue?

Thanks for the feedback so far.

Pazekal90 commented 2 years ago

@mohitpanjwani Ihm Talking about the static button in mails and the "pdf link" generated by me in the admin interface.

image

Already installed 6.0.5 and retested. Problem still present. Sorry :/

mohitpanjwani commented 2 years ago

@mohitpanjwani Ihm Talking about the static button in mails and the "pdf link" generated by me in the admin interface. image

Already installed 6.0.5 and retested. Problem still present. Sorry :/

The pdf link no longer works without authentication but button link on emails should work 😅.

Never-mind I’ll see if we can reproduce this tomorrow on my end.

Pazekal90 commented 2 years ago

ah ok.. But i checked it now twice again. The link in the mails does not work without auth. Checked this button at the bottom of my mails.

image
Pazekal90 commented 2 years ago

@mohitpanjwani Have you already checked this issue? I can't send Invoices to my customers at the moment. Because they can't view them.

Pazekal90 commented 2 years ago

@mohitpanjwani Tested a little. The problem is that the preview of the link does not work only. After i sent the mail the link is correct. That is the problem.

prohtex commented 2 years ago

@mohitpanjwani This is an urgent issue for us too. None of my clients can view their public PDF links after updating to 6.0.6! Is it possible to introduce a setting so that the user can choose whether to allow these links to be public?

profiteroles1 commented 2 years ago

@mohitpanjwani I am also having this issue after upgrading. In the past we sent out thousands and thousands of emails with PDF links in them and we need these legacy links to continue to work. I understand that there's new functionality, and that the preferred method for the user to view a public PDF is to use the token generated in email_logs. I understand why-this enables the admin to expire these tokens, and adds extra security. But this should be the admin's choice. It is not possible in every case to require the user to use a portal with authentication. We also send PDF links constantly with text messages and other platforms. PLEASE add an option for the PDF links to be public!

C-Blais commented 1 year ago

Experiencing this issue as well and it has been over a year since the last comment; is there any progress on this?

profiteroles1 commented 8 months ago

Experiencing this issue as well and it has been over a year since the last comment; is there any progress on this?

I forget where but there's a quick change you can make to the codebase to fix. We just ended up forking our install and applied dozens of patches to the various bugs. Still waiting on a fix for the worst bug which is that the toggle state of custom fields is not recorded at all...