crater-invoice / crater

Open Source Invoicing Solution for Individuals & Businesses
https://craterapp.com
GNU Affero General Public License v3.0
7.87k stars 1.57k forks source link

Please Help me Add Indonesian Language #976

Open nurhamdaniab opened 2 years ago

nurhamdaniab commented 2 years ago

I've translated and added the file id.json and have made the language in the System but why can't the application be applied to Indonesian and still use English ?

Attached screenshot : https://www.optionstudio.id/Screenshoot/screencapture-billing-optionstudio-id-admin-settings-account-settings-2022-06-28-14_54_47.png

https://www.optionstudio.id/Screenshoot/screencapture-billing-optionstudio-id-admin-settings-preferences-2022-06-28-14_54_56.png

rihards-simanovics commented 2 years ago

@nurhamdaniab for your new locale to be registered it is not enough to simply add a file with translated strings, you also must let the app know what the locale code and name is. Please read this guide on how to register a new locale in Laravel (the base PHP framework used by this project): https://lokalise.com/blog/laravel-localization-step-by-step

nurhamdaniab commented 2 years ago

@rihards-simanovics Locale Code and Name already created, but still not working

Attached screenshot : https://www.optionstudio.id/Screenshoot/screencapture-iix300-cloudhost-id-2083-cpsess8893531205-frontend-jupiter-filemanager-editit-html-2022-06-28-22_38_34.png

https://www.optionstudio.id/Screenshoot/screencapture-iix300-cloudhost-id-2083-cpsess8893531205-frontend-jupiter-filemanager-editit-html-2022-06-28-22_38_25.png

rihards-simanovics commented 2 years ago

hi @nurhamdaniab sorry but I'm unable to view the screenshots you've sent; I am unauthorised. please attach the images in comment itself, just drag and drop the image in your reply here:

image

image

nurhamdaniab commented 2 years ago

Hi @rihards-simanovics Sorry because I'm a newbie at this screencapture-iix300-cloudhost-id-2083-cpsess8893531205-frontend-jupiter-filemanager-editit-html-2022-06-28-22_38_25 screencapture-iix300-cloudhost-id-2083-cpsess8893531205-frontend-jupiter-filemanager-editit-html-2022-06-28-22_38_34

rihards-simanovics commented 2 years ago

hmm, on first glance all seems well, can you try rebuilding the frontend with npm run build, perhaps the locale is registered but is not being displayed in UI?

If someone else knows how Crater handles new locale integration, please feel free correct me.

nurhamdaniab commented 2 years ago

@rihards-simanovics How do I check or change npm run build, because I don't know that

I installed this App in cPanel

rihards-simanovics commented 2 years ago

it's a command you need to enter in the terminal but since from the sound of it you have no knowledge of that it might be best if you make a PR request with the new locale file and request someone there to lend you a hand at implementing it.

nurhamdaniab commented 2 years ago

@rihards-simanovics Ok thank you my brother.