search

craue / CraueConfigBundle

Database-stored settings made available via a service for your Symfony project.
MIT License
173 stars 35 forks source link

Allow string values longer than 255 chars #18

Closed rvanlaak closed 9 years ago

rvanlaak commented 9 years ago

... because the settings can also be used to for instance store customer's email autographs.

craue commented 9 years ago

This was already suggested in #5. :smirk:

rvanlaak commented 9 years ago

You're totally right, but that issue does not have a solution for that. What do you suggest?

craue commented 9 years ago

As mentioned over there, when things get more complicated, you would need a custom approach anyway. But I wouldn't try to store running text (like an email footer) in such a setting because probably you'll also need translations for it.

rvanlaak commented 9 years ago

You're right about the translations, but for now it is the best solution. What about adding an extra field to the Setting that defines the Doctrine type, and always let Doctrine serialize the value? Would that work?

craue commented 9 years ago

This is the same discussion as in #5. :smile: I'd like to keep the bundle as simple as it is.

rvanlaak commented 9 years ago

The Setting entity mapping is coded using annotations, which makes it impossible to override it. So what I'd like to propose is to move from Annotations to a yml file so the entity mapping can be overridden in /app/Resources/CraueConfigBundle. That way the bundle doesn't change, but allows others to fix this.

craue commented 9 years ago

Could you open a new issue to discuss this?