craue / CraueConfigBundle

Database-stored settings made available via a service for your Symfony project.

MIT License

173 stars 35 forks source link

[#SymfonyConHackday2017] SF4 compatibility update #39

Closed michalkurzeja closed 6 years ago

michalkurzeja commented 6 years ago

SymfonyConHackday2017

coveralls commented 6 years ago

Coverage remained the same at 97.531% when pulling e7dd8ca30c2164da2461c41b78814b5cfaad90ba on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

coveralls commented 6 years ago

Coverage remained the same at 97.531% when pulling e591aa4e901cf5ba26b3fc58a4f5c75add12b352 on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

coveralls commented 6 years ago

Coverage remained the same at 97.531% when pulling e591aa4e901cf5ba26b3fc58a4f5c75add12b352 on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

coveralls commented 6 years ago

Coverage decreased (-44.9%) to 52.632% when pulling 7b6a741d4dc67f6102f73c441695d9b518c365a5 on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

coveralls commented 6 years ago

Coverage decreased (-44.9%) to 52.632% when pulling 7b6a741d4dc67f6102f73c441695d9b518c365a5 on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

coveralls commented 6 years ago

Coverage remained the same at 97.531% when pulling 1eeada3faf1184c94e97a76ec2530a934d411807 on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

coveralls commented 6 years ago

Coverage remained the same at 97.531% when pulling 1eeada3faf1184c94e97a76ec2530a934d411807 on michalkurzeja:sf4-compat into eb0a0b7387ffaecd3fd261089e9c06224862a8ce on craue:master.

craue commented 6 years ago

I prefer to wait for the release of Symfony 4.0. Would you update the PR once that happened?

What's the reason for getting rid of Assetic?

craue commented 6 years ago

/ping @michalkurzeja

craue commented 6 years ago

Due to the lack of response, I've did it in #41 now.