add autowiring alias and update instructions for reading/writing settings within a controller

craue / CraueConfigBundle

Database-stored settings made available via a service for your Symfony project.

MIT License

173 stars 35 forks source link

add autowiring alias and update instructions for reading/writing settings within a controller #57

Closed craue closed 3 years ago

craue commented 4 years ago

closes #49

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 4db5557851686ab1bb778b6eca20405dab7e7040 on autowiring into a5b83d64f38e0cce087fe0e06b9c5ec90e57e0a2 on master.

Lennix commented 3 years ago

Is there a specific reason why this wasn't merged yet?

craue commented 3 years ago

@Lennix, I hoped for some feedback in #49, that's why. 😏

Lennix commented 3 years ago

@craue It works :+1: On master (without any special changes to services.yml) I get this error:

Cannot autowire argument $config of "myAction": it references class "Craue\ConfigBundle\Util\Config" but no such service exists. You should maybe alias this class to the existing "craue_config_default" service.

With this PR it works.

craue commented 3 years ago

So let's just merge it...

Lennix commented 3 years ago

Thank you.